chore: fixes tests

Author: JohannesHoppe

docs/README_contributors.md

@@ -150,6 +150,7 @@ npm test
 
 ```
 cd ngx-deploy-starter/src
+npx prettier --write '**/*'
 npm run build
 npm run test
 npm publish dist --access public

src/deploy/actions.spec.ts

@@ -70,15 +70,13 @@ describe('Deploy Angular apps', () => {
         ___?: ScheduleOptions
       ) =>
         Promise.resolve({
-          result: Promise.resolve(
-            createBuilderOutputMock(false, 'build error test')
-          )
+          result: Promise.resolve(createBuilderOutputMock(false))
         } as BuilderRun);
       try {
         await deploy(mockEngine, context, 'host', {});
         fail();
       } catch (e) {
-        expect(e.message).toMatch(/build error test/);
+        expect(e.message).toEqual('Error while building the app.');
       }
     });
   });
@@ -112,18 +110,16 @@ const initMocks = () => {
       Promise.resolve({} as BuilderRun),
     scheduleTarget: (_: Target, __?: JsonObject, ___?: ScheduleOptions) =>
       Promise.resolve({
-        result: Promise.resolve(createBuilderOutputMock(true, ''))
+        result: Promise.resolve(createBuilderOutputMock(true))
       } as BuilderRun)
   };
 };
 
-const createBuilderOutputMock = (
-  success: boolean,
-  error: string
-): BuilderOutput => {
+const createBuilderOutputMock = (success: boolean): BuilderOutput => {
   return {
     info: { info: null },
-    error: error,
+    // unfortunately error is undefined in case of a build errors
+    error: (undefined as unknown) as string,
     success: success,
     target: {} as Target
   };

src/deploy/actions.ts

@@ -49,7 +49,7 @@ export default async function deploy(
     const buildResult = await build.result;
 
     if (!buildResult.success) {
-      throw new Error(buildResult.error);
+      throw new Error('Error while building the app.');
     }
   }
 

src/deploy/builder.ts

@@ -16,50 +16,50 @@ import { Schema } from './schema';
 // createJobHandler() but add typings specific to Architect Builders.
 export default createBuilder<any>(
   async (options: Schema, context: BuilderContext): Promise<BuilderOutput> => {
-    // The project root is added to a BuilderContext.
-    const root = normalize(context.workspaceRoot);
-    const workspace = new experimental.workspace.Workspace(
-      root,
-      new NodeJsSyncHost()
-    );
-    await workspace
-      .loadWorkspaceFromHost(normalize('angular.json'))
-      .toPromise();
+    try {
+      // The project root is added to a BuilderContext.
+      const root = normalize(context.workspaceRoot);
+      const workspace = new experimental.workspace.Workspace(
+        root,
+        new NodeJsSyncHost()
+      );
+      await workspace
+        .loadWorkspaceFromHost(normalize('angular.json'))
+        .toPromise();
 
-    if (!context.target) {
-      throw new Error('Cannot deploy the application without a target');
-    }
+      if (!context.target) {
+        throw new Error('Cannot deploy the application without a target');
+      }
 
-    const targets = workspace.getProjectTargets(context.target.project);
+      const targets = workspace.getProjectTargets(context.target.project);
 
-    if (
-      !targets ||
-      !targets.build ||
-      !targets.build.options ||
-      !targets.build.options.outputPath
-    ) {
-      throw new Error('Cannot find the project output directory');
-    }
+      if (
+        !targets ||
+        !targets.build ||
+        !targets.build.options ||
+        !targets.build.options.outputPath
+      ) {
+        throw new Error('Cannot find the project output directory');
+      }
 
-    // normalizes pathes don't work with all native functions
-    // as a workaround, you can use the following 2 lines
-    const isWin = os.platform() === 'win32';
-    const workspaceRoot = !isWin
-      ? workspace.root
-      : asWindowsPath(workspace.root);
-    // if this is not necessary, use this:
-    // const workspaceRoot =  workspace.root;
+      // normalizes pathes don't work with all native functions
+      // as a workaround, you can use the following 2 lines
+      const isWin = os.platform() === 'win32';
+      const workspaceRoot = !isWin
+        ? workspace.root
+        : asWindowsPath(workspace.root);
+      // if this is not necessary, use this:
+      // const workspaceRoot =  workspace.root;
 
-    try {
       await deploy(
         engine,
         context,
         path.join(workspaceRoot, targets.build.options.outputPath),
         options
       );
     } catch (e) {
-      context.logger.error('Error when trying to deploy:', e);
-      console.error(e);
+      context.logger.error('❌ An error occurred when trying to deploy:');
+      context.logger.error(e.message);
       return { success: false };
     }