fix: .git/.gitignore/Makefile as project root

Author: andreoliwa

src/nitpick/constants.py

@@ -37,6 +37,7 @@
 JAVASCRIPT_PACKAGE_JSON = "package.json"
 JMEX_NITPICK_MINIMUM_VERSION = jmespath.compile("nitpick.minimum_version")
 JMEX_NITPICK_STYLES_INCLUDE = jmespath.compile("nitpick.styles.include")
+MAKEFILE = "Makefile"
 MERGED_STYLE_TOML = "merged-style.toml"
 NITPICK_STYLE_TOML = "nitpick-style.toml"
 PRE_COMMIT_CONFIG_YAML = ".pre-commit-config.yaml"
@@ -60,13 +61,16 @@
 
 # These depend on some constants above, so they can't be sorted automatically
 ROOT_PYTHON_FILES = ("app.py", "wsgi.py", "autoapp.py", PYTHON_MANAGE_PY)
-ROOT_FILES = (
+ROOT_FILES_DIRS = (
     # keep-sorted start
     *ROOT_PYTHON_FILES,
     DOT_NITPICK_TOML,
+    GIT_DIR,
+    GIT_IGNORE,
     GOLANG_MOD,
     GOLANG_SUM,
     JAVASCRIPT_PACKAGE_JSON,
+    MAKEFILE,
     NITPICK_STYLE_TOML,
     PRE_COMMIT_CONFIG_YAML,
     PYTHON_PIPFILE_STAR,

src/nitpick/core.py

@@ -35,7 +35,7 @@
     PROJECT_NAME,
     PYTHON_MANAGE_PY,
     PYTHON_PYPROJECT_TOML,
-    ROOT_FILES,
+    ROOT_FILES_DIRS,
     ROOT_PYTHON_FILES,
 )
 from nitpick.exceptions import QuitComplainingError
@@ -173,7 +173,7 @@ def echo(self, message: str):
 def confirm_project_root(dir_: PathOrStr | None = None) -> Path:
     """Confirm this is the root dir of the project (the one that has one of the ``ROOT_FILES``)."""
     possible_root_dir = Path(dir_ or Path.cwd()).resolve()
-    root_files = glob_files(possible_root_dir, ROOT_FILES)
+    root_files = glob_files(possible_root_dir, ROOT_FILES_DIRS)
     logger.debug(f"Root files found: {root_files}")
 
     if root_files:

tests/test_project.py

@@ -8,9 +8,12 @@
 from nitpick.constants import (
     CONFIG_RUN_NITPICK_INIT_OR_CONFIGURE_STYLE_MANUALLY,
     DOT_NITPICK_TOML,
+    GIT_DIR,
+    GIT_IGNORE,
     GOLANG_MOD,
     GOLANG_SUM,
     JAVASCRIPT_PACKAGE_JSON,
+    MAKEFILE,
     NITPICK_STYLE_TOML,
     PRE_COMMIT_CONFIG_YAML,
     PYTHON_MANAGE_PY,
@@ -195,22 +198,27 @@ def test_has_multiple_config_files(tmp_path, caplog):
 @pytest.mark.parametrize(
     "root_file",
     [
-        DOT_NITPICK_TOML,
-        PRE_COMMIT_CONFIG_YAML,
-        PYTHON_PYPROJECT_TOML,
-        PYTHON_SETUP_PY,
-        PYTHON_SETUP_CFG,
-        "requirements.txt",
-        "requirements_dev.txt",
+        # keep-sorted start
+        "Cargo.lock",
+        "Cargo.toml",
         "Pipfile",
         "Pipfile.lock",
-        PYTHON_TOX_INI,
-        JAVASCRIPT_PACKAGE_JSON,
-        "Cargo.toml",
-        "Cargo.lock",
+        "requirements.txt",
+        "requirements_dev.txt",
+        DOT_NITPICK_TOML,
+        GIT_DIR,
+        GIT_IGNORE,
         GOLANG_MOD,
         GOLANG_SUM,
+        JAVASCRIPT_PACKAGE_JSON,
+        MAKEFILE,
         NITPICK_STYLE_TOML,
+        PRE_COMMIT_CONFIG_YAML,
+        PYTHON_PYPROJECT_TOML,
+        PYTHON_SETUP_CFG,
+        PYTHON_SETUP_PY,
+        PYTHON_TOX_INI,
+        # keep-sorted end
     ],
 )
 def test_use_current_dir_dont_climb_dirs_to_find_project_root(tmp_path, root_file):