Skip to content

Commit fccd34a

Browse files
TrottOlivier Martin
authored andcommitted
test: refactor test-dns-regress-6244.js
* Move from parallel to internet because it performs a DNS query * Provide link to relevant issue in comments * Remove unnecessary explicit no-op function PR-URL: nodejs#13058 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
1 parent b8585e4 commit fccd34a

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,6 @@
2323
const common = require('../common');
2424
const dns = require('dns');
2525

26-
// Should not segfault, see #6244.
27-
dns.resolve4('127.0.0.1', common.mustCall(() => { }));
26+
// Should not segfault.
27+
// Ref: https://github.com/nodejs/node-v0.x-archive/issues/6244
28+
dns.resolve4('127.0.0.1', common.mustCall());

0 commit comments

Comments
 (0)