Commit eb6dc56
committed
iio: adc: ad9361: use gpiod_set_value_cansleep() when resetting chip
This appears when using some GPIO drivers that enable `can_sleep` to true.
This (`can_sleep`) seems to be a debugging facility, that is also enabled by
the PCA953x driver (used for the SidekiqZ2 GPIO expanders).
Even though `can_sleep` is true, the kernel must still compile the `DEBUG`
macro to actually call more debug code, so in essence the cansleep()
variants are only useful when compiling the code for debugging.
The warning is more harmless (as it seems), and it's a lot of dmesg log-spam.
Kernel warnings look like this:
```
------------[ cut here ]------------
WARNING: CPU: 0 PID: 1 at drivers/gpio/gpiolib.c:2626 gpiod_set_value+0x70/0xa8
Modules linked in:
CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.9.0-04227-g8a37c19debc4 #3
Hardware name: Xilinx Zynq Platform
[<c0015a28>] (unwind_backtrace) from [<c0012730>] (show_stack+0x10/0x14)
[<c0012730>] (show_stack) from [<c017d2dc>] (dump_stack+0x80/0xa0)
[<c017d2dc>] (dump_stack) from [<c0022190>] (__warn+0xcc/0xfc)
[<c0022190>] (__warn) from [<c0022264>] (warn_slowpath_null+0x1c/0x24)
[<c0022264>] (warn_slowpath_null) from [<c01a2344>] (gpiod_set_value+0x70/0xa8)
[<c01a2344>] (gpiod_set_value) from [<c0365f0c>] (ad9361_reset+0x28/0xa0)
[<c0365f0c>] (ad9361_reset) from [<c036b13c>] (ad9361_probe+0x1a64/0x21cc)
[<c036b13c>] (ad9361_probe) from [<c02214f0>] (spi_drv_probe+0x84/0xa0)
[<c02214f0>] (spi_drv_probe) from [<c01df2e4>] (driver_probe_device+0x12c/0x294)
[<c01df2e4>] (driver_probe_device) from [<c01df4cc>] (__driver_attach+0x80/0xa4)
[<c01df4cc>] (__driver_attach) from [<c01dda7c>] (bus_for_each_dev+0x6c/0x90)
[<c01dda7c>] (bus_for_each_dev) from [<c01dea14>] (bus_add_driver+0xc8/0x1e4)
[<c01dea14>] (bus_add_driver) from [<c01dfcdc>] (driver_register+0x9c/0xe0)
[<c01dfcdc>] (driver_register) from [<c00097fc>] (do_one_initcall+0xac/0x150)
[<c00097fc>] (do_one_initcall) from [<c05e2d5c>] (kernel_init_freeable+0x120/0x1e8)
[<c05e2d5c>] (kernel_init_freeable) from [<c04796e8>] (kernel_init+0x8/0xf4)
[<c04796e8>] (kernel_init) from [<c000ef78>] (ret_from_fork+0x14/0x3c)
---[ end trace 0bb33d2be832b243 ]---
------------[ cut here ]------------
WARNING: CPU: 0 PID: 1 at drivers/gpio/gpiolib.c:2626 gpiod_set_value+0x70/0xa8
Modules linked in:
CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 4.9.0-04227-g8a37c19debc4 #3
Hardware name: Xilinx Zynq Platform
[<c0015a28>] (unwind_backtrace) from [<c0012730>] (show_stack+0x10/0x14)
[<c0012730>] (show_stack) from [<c017d2dc>] (dump_stack+0x80/0xa0)
[<c017d2dc>] (dump_stack) from [<c0022190>] (__warn+0xcc/0xfc)
[<c0022190>] (__warn) from [<c0022264>] (warn_slowpath_null+0x1c/0x24)
[<c0022264>] (warn_slowpath_null) from [<c01a2344>] (gpiod_set_value+0x70/0xa8)
[<c01a2344>] (gpiod_set_value) from [<c0365f28>] (ad9361_reset+0x44/0xa0)
[<c0365f28>] (ad9361_reset) from [<c036b13c>] (ad9361_probe+0x1a64/0x21cc)
[<c036b13c>] (ad9361_probe) from [<c02214f0>] (spi_drv_probe+0x84/0xa0)
[<c02214f0>] (spi_drv_probe) from [<c01df2e4>] (driver_probe_device+0x12c/0x294)
[<c01df2e4>] (driver_probe_device) from [<c01df4cc>] (__driver_attach+0x80/0xa4)
[<c01df4cc>] (__driver_attach) from [<c01dda7c>] (bus_for_each_dev+0x6c/0x90)
[<c01dda7c>] (bus_for_each_dev) from [<c01dea14>] (bus_add_driver+0xc8/0x1e4)
[<c01dea14>] (bus_add_driver) from [<c01dfcdc>] (driver_register+0x9c/0xe0)
[<c01dfcdc>] (driver_register) from [<c00097fc>] (do_one_initcall+0xac/0x150)
[<c00097fc>] (do_one_initcall) from [<c05e2d5c>] (kernel_init_freeable+0x120/0x1e8)
[<c05e2d5c>] (kernel_init_freeable) from [<c04796e8>] (kernel_init+0x8/0xf4)
[<c04796e8>] (kernel_init) from [<c000ef78>] (ret_from_fork+0x14/0x3c)
---[ end trace 0bb33d2be832b244 ]---
```
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>1 parent d1c3984 commit eb6dc56
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
934 | 934 | | |
935 | 935 | | |
936 | 936 | | |
937 | | - | |
| 937 | + | |
938 | 938 | | |
939 | | - | |
| 939 | + | |
940 | 940 | | |
941 | 941 | | |
942 | 942 | | |
| |||
0 commit comments