Skip to content

Commit 4335686

Browse files
committed
test(cgroups): add code coverage for job annotation transform plugin
1 parent f7132b6 commit 4335686

5 files changed

Lines changed: 484 additions & 210 deletions

File tree

plugins/cgroups/oar/src/source.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,14 @@ impl JobSourceSetup {
3131
let trigger = TriggerSpec::at_interval(config.poll_interval);
3232
match config.oar_version {
3333
OarVersion::Oar2 => Ok(Self {
34-
tagger: tagger,
34+
tagger,
3535
username_from_userid: false,
3636
trigger,
3737
tracker,
3838
jobs_only: config.jobs_only,
3939
}),
4040
OarVersion::Oar3 => Ok(Self {
41-
tagger: tagger,
41+
tagger,
4242
username_from_userid: true,
4343
trigger,
4444
tracker,

plugins/cgroups/util-cgroups-plugins/src/job_annotation_transform.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ impl<T: JobTagger> Transform for JobAnnotationTransform<T> {
6363
Ok(())
6464
}
6565

66-
fn finish(&mut self, ctx: &TransformContext) -> Result<(), TransformError> {
66+
fn finish(&mut self, _ctx: &TransformContext) -> Result<(), TransformError> {
6767
Ok(())
6868
}
6969
}
@@ -73,7 +73,7 @@ impl<T: JobTagger> Transform for JobAnnotationTransform<T> {
7373
pub struct SharedCgroupHierarchy(Arc<Mutex<Option<CgroupHierarchy>>>);
7474

7575
impl SharedCgroupHierarchy {
76-
fn set(&self, value: CgroupHierarchy) {
76+
pub fn set(&self, value: CgroupHierarchy) {
7777
*self.0.lock().unwrap() = Some(value);
7878
}
7979
}

plugins/cgroups/util-cgroups-plugins/src/lib.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,3 @@ pub mod job_annotation_transform;
1010
pub mod metrics;
1111
pub mod regex;
1212
mod self_stop;
13-
mod tests;

plugins/cgroups/util-cgroups-plugins/src/tests.rs

Lines changed: 0 additions & 205 deletions
This file was deleted.

0 commit comments

Comments
 (0)