feat: add transactionReceipts into SubscriptionKind
#2974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10gic
requested review from
DaniPopes,
klkvr,
mattsse and
yash-atreya
as code owners
Author
|
Hi @DaniPopes, @mattsse, @klkvr, hope you're doing well. When you have a chance, could you take a look at this PR? Any feedback would be great. Thanks! |
mattsse
reviewed
Oct 14, 2025
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this makes sense, supportive, just need to figure out how to roll this out without introducing breaking changes on reth
mattsse
requested review from
grandizzy,
onbjerg and
zerosnacks
as code owners
mattsse
approved these changes
Oct 15, 2025
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this lgtm,
blocking this until next reth release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add transactionReceipts for receipts notification. For more information, see: ethereum/go-ethereum#32697