Skip to content

Conversation

@jonnynch
Copy link
Contributor

@jonnynch jonnynch commented Nov 7, 2025

As a webview beta user, my phone webview version is 143.0.7499.15.
Streaming from my Nest Doorbell does not work in the Home Assistant mobile app, while it works correctly in both Chrome and Firefox.

Error Observed:

Failed to connect WebRTC stream: Failed to execute 'setRemoteDescription' on 'RTCPeerConnection': Failed to set remote answer sdp: Incompatible send direction

Home assistant issue has been raised
Reference: home-assistant/frontend#27781

This issue is related to a recent change in Chromium that enforces stricter validation on the answer SDP direction.
Reference: https://webrtc-review.googlesource.com/c/src/+/413340/7/pc/sdp_offer_answer.cc#b313

Fix:
This PR extends the SDP direction fix to all browsers, not just Chrome.
The test case has been updated accordingly.

Verification:
Streaming has been tested and confirmed working in:
Home Assistant mobile app (WebView 143.0.7499.15)
Chrome 142.0.7444.48
Firefox 144.0.2

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.71%. Comparing base (bd6e01e) to head (0987b73).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1206   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files          23       23           
  Lines        2098     2098           
=======================================
  Hits         2029     2029           
  Misses         69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change -- one small request for the tests please.

Split the SDP checks for firefox and chrome into separate tests.
@allenporter allenporter merged commit 43d3d44 into allenporter:main Nov 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants