Fix WebRTC Streaming Issue in Home Assistant App (WebView Beta 143) #1206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a webview beta user, my phone webview version is 143.0.7499.15.
Streaming from my Nest Doorbell does not work in the Home Assistant mobile app, while it works correctly in both Chrome and Firefox.
Error Observed:
Home assistant issue has been raised
Reference: home-assistant/frontend#27781
This issue is related to a recent change in Chromium that enforces stricter validation on the answer SDP direction.
Reference: https://webrtc-review.googlesource.com/c/src/+/413340/7/pc/sdp_offer_answer.cc#b313
Fix:
This PR extends the SDP direction fix to all browsers, not just Chrome.
The test case has been updated accordingly.
Verification:
Streaming has been tested and confirmed working in:
Home Assistant mobile app (WebView 143.0.7499.15)
Chrome 142.0.7444.48
Firefox 144.0.2