feature: add bind mode #937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
reviewed
Mar 23, 2018
apis/server/container_bridge.go
Outdated
| } | ||
| } | ||
|
|
||
| if len(meta.Mounts) > 0 { |
There was a problem hiding this comment.
I do not think we need this judgement, the range will ignore the situation of length 0 automatically.
allencloud
reviewed
Mar 23, 2018
| return arr, nil | ||
| } | ||
|
|
||
| func parseBindMode(mp *types.MountPoint, mode string) error { |
There was a problem hiding this comment.
I am afraid that we need unit test for this function. 😄
There was a problem hiding this comment.
I have added unit tests. PTAL.
YaoZengzeng
reviewed
Mar 23, 2018
daemon/mgr/spec_volume.go
Outdated
| rootfspg := s.Linux.RootfsPropagation | ||
| // Set rootfs propagation, default setting is private. | ||
| switch pg { | ||
| case "shared", "rshare": |
There was a problem hiding this comment.
Only "shared" and "rshared" are valid?
Codecov Report
@@ Coverage Diff @@
## master #937 +/- ##
=========================================
+ Coverage 13.81% 14.02% +0.2%
=========================================
Files 125 125
Lines 8395 8469 +74
=========================================
+ Hits 1160 1188 +28
- Misses 7135 7181 +46
Partials 100 100
Continue to review full report at Codecov.
|
Add bind mode, it contains: "ro/rw/dr/rr/z/Z/nocopy/private/rprivate/slave/rslave/shared/rshared" common mode for all bind are: "ro/rw/z/Z", "dr/rr/nocopy" just for volume, "private/rprivate/slave/rslave/shared/rshared" just for rootfs. Signed-off-by: Rudy Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add bind mode, it contains:
"ro/rw/dr/rr/z/Z/nocopy/private/rprivate/slave/rslave/shared/rshared"
common mode for all bind are: "ro/rw"，"z/Z" will be supported later,
"dr/rr/nocopy" just for volume, dr means direct replace, rr means random replace, nocopy will be supported later.
"private/rprivate/slave/rslave/shared/rshared" just for rootfs.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
see test/cli_volume_test.go:TestVolumeBindReplaceMode
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang [email protected]