bugfix: pull a image failed will lead to list images failed #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #926 +/- ##
==========================================
- Coverage 13.49% 13.49% -0.01%
==========================================
Files 121 121
Lines 7764 7768 +4
==========================================
Hits 1048 1048
- Misses 6626 6630 +4
Partials 90 90
Continue to review full report at Codecov.
|
allencloud
reviewed
Mar 20, 2018
ctrd/image.go
Outdated
| // occur error, skip it | ||
| if err != nil { | ||
| return nil, err | ||
| logrus.Errorf("Get image %s size failed: %v", image.Name, err) |
There was a problem hiding this comment.
("failed to get image size of %s: %v, image.Name, err)
How about that and keep consistent in the following file? @HusterWan
Signed-off-by: Michael Wan <[email protected]>
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Wan [email protected]
Ⅰ. Describe what this PR did
fix: pull a image failed will lead to list images failed
Ⅱ. Does this pull request fix one issue?
fixes #924
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews