-
Notifications
You must be signed in to change notification settings - Fork 944
feature: add disable-bridge switch #2760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2760 +/- ##
=========================================
Coverage ? 69.37%
=========================================
Files ? 277
Lines ? 17421
Branches ? 0
=========================================
Hits ? 12085
Misses ? 4009
Partials ? 1327
|
487e52f to
ea247fb
Compare
fuweid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature change is LGTM.
But I have some questions about test cases.
|
Could you add more details into the PR description? |
|
@allencloud disable-bridge function same as moby. |
f6796a5 to
a5c4a27
Compare
add disable-bridge switch Signed-off-by: Rudy Zhang <[email protected]>
fuweid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
add disable-bridge switch for daemon config
disable-bridge is a daemon feature same as moby.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Added
Ⅳ. Describe how to verify it
ci pass
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang [email protected]