Skip to content

Conversation

@rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented Mar 18, 2019

Ⅰ. Describe what this PR did

add disable-bridge switch for daemon config
disable-bridge is a daemon feature same as moby.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Added

Ⅳ. Describe how to verify it

ci pass

Ⅴ. Special notes for reviews

Signed-off-by: Rudy Zhang [email protected]

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@1aa370d). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2760   +/-   ##
=========================================
  Coverage          ?   69.37%           
=========================================
  Files             ?      277           
  Lines             ?    17421           
  Branches          ?        0           
=========================================
  Hits              ?    12085           
  Misses            ?     4009           
  Partials          ?     1327
Flag Coverage Δ
#criv1alpha2_test 39.37% <50%> (?)
#integration_test_0 36.55% <50%> (?)
#integration_test_1 35.8% <50%> (?)
#integration_test_2 36.49% <50%> (?)
#integration_test_3 35.49% <50%> (?)
#node_e2e_test 35.2% <50%> (?)
#unittest 28.5% <ø> (?)
Impacted Files Coverage Δ
network/mode/init.go 67.64% <50%> (ø)

@rudyfly rudyfly force-pushed the disable_bridge branch 5 times, most recently from 487e52f to ea247fb Compare March 19, 2019 05:45
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature change is LGTM.

But I have some questions about test cases.

@allencloud
Copy link
Collaborator

Could you add more details into the PR description?
What this pr solves? What the reason? What the scenario? @rudyfly

@rudyfly
Copy link
Collaborator Author

rudyfly commented Mar 20, 2019

@allencloud disable-bridge function same as moby.

@rudyfly rudyfly force-pushed the disable_bridge branch 2 times, most recently from f6796a5 to a5c4a27 Compare March 20, 2019 07:11
add disable-bridge switch

Signed-off-by: Rudy Zhang <[email protected]>
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 9e6acbc into AliyunContainerService:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants