feature: CONTAINER_PAUSE state for CRI #2681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2681 +/- ##
==========================================
- Coverage 69.32% 69.31% -0.02%
==========================================
Files 285 285
Lines 18959 18948 -11
==========================================
- Hits 13144 13134 -10
+ Misses 4346 4345 -1
Partials 1469 1469
|
zhuangqh
commented
Jan 22, 2019
| // * Case 2: container has failed to start; it has a zero finishedAt | ||
| // time, but a non-zero exit code. | ||
| // * Case 3: container has been created, but not started (yet). | ||
| finishTime, err := time.Parse(utils.TimeLayout, container.State.FinishedAt) |
Contributor
Author
There was a problem hiding this comment.
PouchContainer will promise the consistency about FinishedAt, CreatedAt, StartedAt and container state
zhuangqh
changed the title
zhuangqh
force-pushed
the
fix-cri-pause-state
branch
from
5aef036 to
6f6102e
Compare
Signed-off-by: zhuangqh <[email protected]>
zhuangqh
force-pushed
the
fix-cri-pause-state
branch
from
6f6102e to
07a0ee5
Compare
HusterWan
reviewed
Jan 22, 2019
| return runtime.ContainerState_CONTAINER_RUNNING | ||
| case apitypes.StatusExited: | ||
| return runtime.ContainerState_CONTAINER_EXITED | ||
| func toCriContainerState(state *apitypes.ContainerState) (criState runtime.ContainerState, reason string) { |
Contributor
There was a problem hiding this comment.
Why just define the return type runtime.ContainerState, string and return the value in the function?
Contributor
Author
There was a problem hiding this comment.
Did you mean the named return value?
Contributor
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Pause/Unpause container interface are added to CRI, but missing a PAUSE state from
ContainerStatusorListContainerto figure out the paused container.Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
cri test here.
alibaba-archive/cri-tools#11
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Signed-off-by: zhuangqh [email protected]