test: make TestPouchRestartExitedContainer be happy #2658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2658 +/- ##
==========================================
- Coverage 69.61% 69.49% -0.12%
==========================================
Files 283 283
Lines 18900 18900
==========================================
- Hits 13157 13135 -22
- Misses 4269 4287 +18
- Partials 1474 1478 +4
|
fuweid
reviewed
Jan 10, 2019
sometime, sleep 0.01s in container maybe not stopped after sleep 2s in host, so restart container will be failed. Signed-off-by: Rudy Zhang <[email protected]>
Contributor
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
sometime, sleep 0.01s in container maybe not stopped
after sleep 2s in host, so restart container will be failed.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
NA
Ⅳ. Describe how to verify it
ci pass
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang [email protected]