Skip to content

Conversation

@zhuangqh
Copy link
Contributor

@zhuangqh zhuangqh commented Jan 5, 2019

Ⅰ. Describe what this PR did

regenerate a x509 key pair for testing.

add a script to regenerate.

Ⅱ. Does this pull request fix one issue?

fixes #2650

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

without unit test error

--- FAIL: TestTLSDialer (0.01s)
    syslog_test.go:193: failed to dial: x509: cannot validate certificate for 127.0.0.1 because it doesn't contain any IP SANs

Ⅴ. Special notes for reviews

together add a script to regenerate them

Signed-off-by: zhuangqh <[email protected]>
@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #2651 into master will increase coverage by 10.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2651       +/-   ##
===========================================
+ Coverage   59.42%   69.52%   +10.09%     
===========================================
  Files         277      280        +3     
  Lines       18720    18845      +125     
===========================================
+ Hits        11125    13102     +1977     
+ Misses       6017     4272     -1745     
+ Partials     1578     1471      -107
Flag Coverage Δ
#criv1alpha1test 31.25% <ø> (-0.14%) ⬇️
#criv1alpha2test 35.58% <ø> (-0.12%) ⬇️
#integrationtest 41.64% <ø> (-0.04%) ⬇️
#nodee2etest 32.72% <ø> (-0.01%) ⬇️
#unittest 26.91% <ø> (?)
Impacted Files Coverage Δ
ctrd/watch.go 81.69% <0%> (-2.82%) ⬇️
cri/v1alpha1/cri.go 59.43% <0%> (-0.67%) ⬇️
cri/v1alpha2/cri.go 67.57% <0%> (-0.25%) ⬇️
daemon/mgr/container.go 58.79% <0%> (-0.22%) ⬇️
credential/credential.go 0% <0%> (ø)
credential/file_store.go 0% <0%> (ø)
credential/helpers.go 44.44% <0%> (ø)
storage/quota/quota.go 45.04% <0%> (+1.8%) ⬆️
pkg/meta/boltdb.go 69.41% <0%> (+2.35%) ⬆️
daemon/mgr/image_utils.go 85.45% <0%> (+3.63%) ⬆️
... and 122 more

@pouchrobot pouchrobot added areas/test kind/bug This is bug report for project size/L labels Jan 5, 2019
@zhuangqh zhuangqh added the priority/P1 this is high priority that all maintainers should stop to handle this issue label Jan 5, 2019
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

areas/test kind/bug This is bug report for project priority/P1 this is high priority that all maintainers should stop to handle this issue size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[test] unit test CI failed due to case TestTLSDialer fails with x509: certificate has expired

3 participants