Skip to content

Conversation

@allencloud
Copy link
Collaborator

@allencloud allencloud commented Dec 28, 2018

Signed-off-by: Allen Sun [email protected]

Ⅰ. Describe what this PR did

This PR added two parts of things:

  1. add @zhuangqh and @fuweid in the maintainers list, since both of them has invested lots of energy in making PouchContainer much better. @zhuangqh is doing great work on standardizing CRI implementation in pouchd and some other meaningful work. For @fuweid, he is almost involved in all kinds of part in pouchd, no only the software component, but also the organization effort for the maintainers meetings. In addition, he did a lot to spread PouchContainer in the ecosystem. I think both of them are qualified maintainers which have ability to lead the project to success. I propose to add them into the maintainer's list.

  2. add component owner/backup policy for projects. In order to make all components in PouchContainer well-maintained, an owner/backup responsibility policy is set for all maintainers. No matter the owner or the backup, they have responsibilities to make/review design and programme code for the corresponding component. They work for success of the decoupled component, and efforts all maintainers do guarantee PouchContainer's success.

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need

Ⅳ. Describe how to verify it

no need

Ⅴ. Special notes for reviews

cc @alibaba/pouch

@codecov
Copy link

codecov bot commented Dec 28, 2018

Codecov Report

❗ No coverage uploaded for pull request head (add-owner-backup@727c0ad). Click here to learn what that means.
The diff coverage is n/a.

@allencloud allencloud changed the title doc: add two maintainers and component owner/backup policy for project docs: add two maintainers and component owner/backup policy for project Dec 28, 2018
@ZYecho
Copy link
Contributor

ZYecho commented Jan 2, 2019

LGTM

1 similar comment
@Ace-Tang
Copy link
Contributor

Ace-Tang commented Jan 2, 2019

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jan 2, 2019
@fuweid
Copy link
Contributor

fuweid commented Jan 7, 2019

LGTM

1 similar comment
@allencloud
Copy link
Collaborator Author

LGTM

@allencloud allencloud merged commit 05c8c87 into AliyunContainerService:master Jan 7, 2019
@allencloud allencloud deleted the add-owner-backup branch January 7, 2019 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

areas/docs LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants