Skip to content

Conversation

@allencloud
Copy link
Collaborator

@allencloud allencloud commented Dec 24, 2018

Signed-off-by: Allen Sun [email protected]

Ⅰ. Describe what this PR did

Currently in pouchd, it does not support top a paused container, this pull request tries to make it.

Update the container status checking and test cases.

Ⅱ. Does this pull request fix one issue?

fixes #2598

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

added

Ⅳ. Describe how to verify it

none

Ⅴ. Special notes for reviews

cc @drpmma

@codecov
Copy link

codecov bot commented Dec 24, 2018

Codecov Report

Merging #2606 into master will decrease coverage by 42.6%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2606       +/-   ##
===========================================
- Coverage   69.38%   26.78%   -42.61%     
===========================================
  Files         279      229       -50     
  Lines       18825    16933     -1892     
===========================================
- Hits        13062     4535     -8527     
- Misses       4287    12089     +7802     
+ Partials     1476      309     -1167
Flag Coverage Δ
#criv1alpha1test ?
#criv1alpha2test ?
#integrationtest ?
#nodee2etest ?
#unittest 26.78% <0%> (ø) ⬆️
Impacted Files Coverage Δ
daemon/mgr/container.go 0% <0%> (-59.01%) ⬇️
cri/v1alpha1/cri_types.go 0% <0%> (-100%) ⬇️
daemon/mgr/events.go 0% <0%> (-100%) ⬇️
daemon/logger/logmessage.go 0% <0%> (-100%) ⬇️
daemon/mgr/spec_apparmor_linux_unsupported.go 0% <0%> (-100%) ⬇️
pkg/httputils/http_error.go 0% <0%> (-100%) ⬇️
pkg/meta/errors.go 0% <0%> (-100%) ⬇️
cri/v1alpha2/cri_types.go 0% <0%> (-100%) ⬇️
apis/server/router.go 0% <0%> (-91.31%) ⬇️
apis/server/container_bridge.go 0% <0%> (-87.43%) ⬇️
... and 163 more

@pouchrobot pouchrobot added kind/bug This is bug report for project size/S labels Dec 24, 2018
@ZYecho
Copy link
Contributor

ZYecho commented Dec 25, 2018

LGTM

@allencloud allencloud merged commit 684c6e5 into AliyunContainerService:master Dec 25, 2018
@allencloud allencloud deleted the top-pausedcon branch December 25, 2018 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug This is bug report for project size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] cannot top a paused container

3 participants