Skip to content

Conversation

@Ace-Tang
Copy link
Contributor

remove check exitcode, check output error is enough

Signed-off-by: Ace-Tang [email protected]

Ⅰ. Describe what this PR did

remove check exitcode, check output error is enough in cli_run_with_privileged_test.go

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

has test

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #2558 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2558      +/-   ##
==========================================
- Coverage   69.09%   69.04%   -0.05%     
==========================================
  Files         278      278              
  Lines       18582    18582              
==========================================
- Hits        12839    12830       -9     
- Misses       4270     4274       +4     
- Partials     1473     1478       +5
Flag Coverage Δ
#criv1alpha1test 30.95% <ø> (-0.15%) ⬇️
#criv1alpha2test 35.59% <ø> (+0.13%) ⬆️
#integrationtest 40.54% <ø> (-0.03%) ⬇️
#nodee2etest 32.48% <ø> (-0.03%) ⬇️
#unittest 26.79% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/ocicni/cni_manager.go 58.82% <0%> (-11.77%) ⬇️
apis/server/utils.go 71.15% <0%> (-3.85%) ⬇️
pkg/meta/store.go 67.44% <0%> (-1.56%) ⬇️
cri/v1alpha2/cri_wrapper.go 64.4% <0%> (-1.2%) ⬇️
daemon/mgr/container_utils.go 83.92% <0%> (-1.2%) ⬇️
cri/v1alpha2/cri.go 68.22% <0%> (-0.37%) ⬇️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
ctrd/image.go 78.94% <0%> (+2.19%) ⬆️
ctrd/watch.go 84.5% <0%> (+2.81%) ⬆️

@Ace-Tang
Copy link
Contributor Author

@fuweid , as you advised, I has fix the test

@allencloud
Copy link
Collaborator

Could you help to take a look of this? @ZYecho 🐳 🦁

@ZYecho
Copy link
Contributor

ZYecho commented Dec 13, 2018

make sense, LGTM

remove check exitcode, check output error is enough

Signed-off-by: Ace-Tang <[email protected]>
@HusterWan
Copy link
Contributor

LGTM

@HusterWan HusterWan merged commit c6a184a into AliyunContainerService:master Dec 14, 2018
@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants