Skip to content

Conversation

@eahydra
Copy link
Contributor

@eahydra eahydra commented Dec 12, 2018

Signed-off-by: Joseph Lee [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fix #964

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Joseph Lee <[email protected]>
@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #2551 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2551      +/-   ##
==========================================
+ Coverage   69.16%   69.21%   +0.04%     
==========================================
  Files         278      278              
  Lines       18552    18552              
==========================================
+ Hits        12831    12840       +9     
+ Misses       4246     4240       -6     
+ Partials     1475     1472       -3
Flag Coverage Δ
#criv1alpha1test 31.09% <0%> (-0.11%) ⬇️
#criv1alpha2test 35.63% <0%> (+0.02%) ⬆️
#integrationtest 40.56% <0%> (-0.02%) ⬇️
#nodee2etest 32.74% <0%> (+0.11%) ⬆️
#unittest 26.8% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pkg/netutils/interface.go 89.04% <0%> (ø) ⬆️
daemon/logger/jsonfile/utils.go 71.54% <0%> (ø) ⬆️
cri/v1alpha1/cri.go 60.26% <0%> (-0.67%) ⬇️
cri/v1alpha2/cri_wrapper.go 64.4% <0%> (ø) ⬆️
daemon/mgr/container.go 58.99% <0%> (+0.21%) ⬆️
cri/v1alpha2/cri_utils.go 89.75% <0%> (+0.28%) ⬆️
cri/v1alpha2/cri.go 68.95% <0%> (+0.36%) ⬆️
ctrd/container.go 59.2% <0%> (+0.79%) ⬆️
apis/server/utils.go 75% <0%> (+3.84%) ⬆️

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Dec 12, 2018
@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @eahydra
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2018

CLA assistant check
All committers have signed the CLA.

@HusterWan
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Dec 12, 2018
return errDone
default:
logrus.Debug("unexpected file change during watching file %v: %v", f.Name(), e.Op)
logrus.Debugf("unexpected file change during watching file %v: %v", f.Name(), e.Op)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@allencloud allencloud merged commit ca885d7 into AliyunContainerService:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GoReport Issue] fix issue for Pouch reported from GoReport

5 participants