Get a valid image user and image uid #2549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2549 +/- ##
==========================================
+ Coverage 69.09% 69.16% +0.06%
==========================================
Files 278 278
Lines 18552 18552
==========================================
+ Hits 12819 12831 +12
- Misses 4253 4254 +1
+ Partials 1480 1467 -13
|
|
|
Collaborator
|
We found this is your first time to contribute to Pouch, @changyaowei |
changyaowei
force-pushed
the
image_cri
branch
from
08b5c18 to
895e6eb
Compare
changyaowei
force-pushed
the
image_cri
branch
from
895e6eb to
263c354
Compare
HusterWan
reviewed
Dec 11, 2018
| imageUID, username := getUserFromImageUser(image.Config.User) | ||
| if imageUID != nil { | ||
| uid.Value = *imageUID | ||
| if image == nil || image.Config == nil { |
Contributor
|
LGTM |
pouchrobot
added
the
LGTM
fuweid
suggested changes
Dec 11, 2018
Contributor
fuweid
left a comment
fuweid
left a comment
There was a problem hiding this comment.
@changyaowei please use git commit -s --amend --no-edit and repush again. We need your sign off before merge 😄
Signed-off-by: changyaowei <[email protected]>
changyaowei
force-pushed
the
image_cri
branch
from
263c354 to
d252659
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Get a valid user and image uid through imageStatus and ListImages CRI
Ⅱ. Does this pull request fix one issue?
fixes #2548
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Modify an exist test case
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews