Skip to content

Conversation

@zhuangqh
Copy link
Contributor

@zhuangqh zhuangqh commented Dec 7, 2018

Signed-off-by: zhuangqh [email protected]

Ⅰ. Describe what this PR did

make it compatible with rich mode container

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

This test would actually allow rich mode container to pass now...

make it compatible with rich mode container

Signed-off-by: zhuangqh <[email protected]>
@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #2544 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2544      +/-   ##
==========================================
- Coverage   69.22%   69.18%   -0.04%     
==========================================
  Files         278      278              
  Lines       18528    18528              
==========================================
- Hits        12826    12819       -7     
- Misses       4244     4247       +3     
- Partials     1458     1462       +4
Flag Coverage Δ
#criv1alpha1test 31.13% <ø> (-0.08%) ⬇️
#criv1alpha2test 35.53% <ø> (-0.12%) ⬇️
#integrationtest 40.56% <ø> (+0.07%) ⬆️
#nodee2etest 32.77% <ø> (ø) ⬆️
#unittest 26.85% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/stream/portforward/httpstream.go 70.94% <0%> (-6.84%) ⬇️
daemon/mgr/snapshot.go 89.85% <0%> (-4.35%) ⬇️
cri/stream/runtime.go 67.85% <0%> (-2.39%) ⬇️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
cri/v1alpha2/cri_wrapper.go 62.4% <0%> (-1.21%) ⬇️
cri/v1alpha2/cri.go 70.06% <0%> (-0.76%) ⬇️
cri/v1alpha1/cri.go 60.26% <0%> (-0.34%) ⬇️
daemon/mgr/container.go 58.69% <0%> (ø) ⬆️
cri/v1alpha2/cri_utils.go 90.04% <0%> (+0.28%) ⬆️
ctrd/container.go 59.2% <0%> (+0.39%) ⬆️
... and 5 more

@zhuangqh zhuangqh requested a review from rudyfly December 7, 2018 15:12
@rudyfly
Copy link
Collaborator

rudyfly commented Dec 8, 2018

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Dec 8, 2018
@rudyfly rudyfly merged commit 9446798 into AliyunContainerService:master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

areas/storage areas/test kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants