bugfix: Fix CopyData in Bind Mount #2527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2527 +/- ##
===========================================
+ Coverage 57.23% 69.22% +11.98%
===========================================
Files 278 278
Lines 18440 18442 +2
===========================================
+ Hits 10554 12766 +2212
+ Misses 6640 4216 -2424
- Partials 1246 1460 +214
|
|
Since we can reproduce the issue, |
rudyfly
reviewed
Dec 4, 2018
|
BTW, can you add a test case to check the |
allencloud
changed the title
OK. Test case is added in the latest patch |
OK. Test case is added in the latest patch |
rudyfly
reviewed
Dec 5, 2018
CopyData is an action which should be enabled only in mount volumes and images. For example: [root@hostname]# pouch run -it --name test2 -v /home/baijia.wr/volume/:/var/ docker.io/library/busybox:latest ls /var/ spool www [root@hostname]# ls /home/baijia.wr/volume/ spool www Without this patch, data is copied form container's dir "/var/" to host's dir "/home/baijia.wr/volume/", that is unexpected. So CopyData should be disabled in bind mount. Signed-off-by: Wang Rui <[email protected]>
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CopyData is an action which should be enabled only in mount volumes and images.
For example:
[root@hostname]# pouch run -it --name test2 -v /home/baijia.wr/volume/:/var/ docker.io/library/busybox:latest ls /var/
spool www
[root@hostname]# ls /home/baijia.wr/volume/
spool www
Without this patch, data is copied form container's dir "/var/" to host's dir "/home/baijia.wr/volume/",
that is unexpected. So CopyData should be disabled in bind mount.
Signed-off-by: Wang Rui [email protected]
Ⅰ. Describe what this PR did
Data will be copied from container to host when bind mount is used, that is unexpected.
For example:
Data is copied form container's dir "/var/" to host's dir "/home/baijia.wr/volume/".
This patch will fix that.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
With this patch, DataCopy is disabled in bind mount.
Ⅴ. Special notes for reviews