Skip to content

Conversation

@Ace-Tang
Copy link
Contributor

criu test is not completed, we should check criu image files have
been dumped, and restored container has the specified process

Signed-off-by: Ace-Tang [email protected]

Ⅰ. Describe what this PR did

I have no idea whether criu test have broken, so I complete the criu test to check

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

criu test is not completed, we should check criu image files have
been dumped, and restored container has the specified process

Signed-off-by: Ace-Tang <[email protected]>
@codecov
Copy link

codecov bot commented Nov 30, 2018

Codecov Report

Merging #2520 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2520      +/-   ##
==========================================
+ Coverage   69.03%   69.12%   +0.09%     
==========================================
  Files         278      278              
  Lines       18454    18454              
==========================================
+ Hits        12739    12756      +17     
+ Misses       4256     4250       -6     
+ Partials     1459     1448      -11
Flag Coverage Δ
#criv1alpha1test 31.39% <ø> (+0.2%) ⬆️
#criv1alpha2test 35.38% <ø> (-0.05%) ⬇️
#integrationtest 40.31% <ø> (-0.09%) ⬇️
#nodee2etest 32.86% <ø> (+0.16%) ⬆️
#unittest 26.72% <ø> (ø) ⬆️
Impacted Files Coverage Δ
daemon/mgr/snapshot.go 89.85% <0%> (-4.35%) ⬇️
ctrd/watch.go 80.28% <0%> (-4.23%) ⬇️
pkg/streams/utils.go 89.28% <0%> (-2.39%) ⬇️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
daemon/mgr/system.go 71.75% <0%> (-1.53%) ⬇️
daemon/mgr/container.go 58.04% <0%> (+0.42%) ⬆️
cri/v1alpha1/cri.go 60.92% <0%> (+0.66%) ⬆️
ctrd/container.go 58.89% <0%> (+0.79%) ⬆️
cri/v1alpha2/cri.go 70.06% <0%> (+0.88%) ⬆️
daemon/mgr/container_utils.go 86.7% <0%> (+1.26%) ⬆️
... and 2 more

@Ace-Tang Ace-Tang changed the title test: fix criu test test: complete criu test Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants