Skip to content

Conversation

@zjumoon01
Copy link
Contributor

@zjumoon01 zjumoon01 commented Nov 26, 2018

Signed-off-by: Wang Rui [email protected]

Ⅰ. Describe what this PR did

Fix indentation and typo in command line help description, such as "pouch upgrade --help"

[root@acs-test3 ~]# pouch upgrade --help
upgrade is a feature to replace a container's image.You can specify the new Entrypoint and Cmd for the new container. When you want to updatea container's image, but inherit the network and volumes of the old container, then you shouldthink about the upgrade feature.

This patch will also fix the command line docs (docs/commandline/*.md) because the docs are auto generated.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

There are also indentation defects in client documents (docs/commandline/*.md)
which are auto generated.

Signed-off-by: Wang Rui <[email protected]>
@codecov
Copy link

codecov bot commented Nov 26, 2018

Codecov Report

❗ No coverage uploaded for pull request head (dev@13576db). Click here to learn what that means.
The diff coverage is n/a.

return ` $ pouch run -d -m 20m --name test registry.hub.docker.com/library/busybox:latest
4c58d27f58d38776dda31c01c897bbf554c802a9b80ae4dc20be1337f8a969f2
$ pouch upgrade --image registry.hub.docker.com/library/hello-world:latest test
test1`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@HusterWan
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Nov 26, 2018
@allencloud
Copy link
Collaborator

LGTM, I do not think that the travisCI in unit test is related to the code change.

@allencloud allencloud merged commit e441275 into AliyunContainerService:master Nov 27, 2018
@zjumoon01 zjumoon01 deleted the dev branch December 5, 2018 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

areas/cli areas/typo LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants