refactor: fix part of megacheck issue #2500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2500 +/- ##
=========================================
Coverage ? 69.19%
=========================================
Files ? 278
Lines ? 18439
Branches ? 0
=========================================
Hits ? 12758
Misses ? 4235
Partials ? 1446
|
ZYecho
force-pushed
the
fix-megacheck
branch
2 times, most recently
from
af42b50 to
bcc8b03
Compare
Contributor
|
please rebase your pr, thanks |
ZYecho
force-pushed
the
fix-megacheck
branch
from
bcc8b03 to
467fbdf
Compare
allencloud
reviewed
Nov 28, 2018
allencloud
reviewed
Nov 28, 2018
| gid int | ||
| finger []string | ||
| userdir string | ||
| shell string |
Collaborator
There was a problem hiding this comment.
please help to check whether these fields are useful in your scope. @Ace-Tang
Contributor
There was a problem hiding this comment.
The code have been changed by @rudyfly once, I think it is why make these filed unused, but the function should be fine
allencloud
reviewed
Nov 28, 2018
allencloud
reviewed
Nov 28, 2018
Collaborator
|
Could you please make this move on ? @ZYecho |
ZYecho
force-pushed
the
fix-megacheck
branch
3 times, most recently
from
06762b7 to
97e1db7
Compare
Contributor
Author
Sorry for late, update. |
ZYecho
force-pushed
the
fix-megacheck
branch
2 times, most recently
from
70bfc52 to
f67c866
Compare
allencloud
reviewed
Dec 2, 2018
allencloud
reviewed
Dec 2, 2018
allencloud
reviewed
Dec 2, 2018
Collaborator
fuweid
reviewed
Dec 3, 2018
fuweid
reviewed
Dec 3, 2018
Signed-off-by: zhangyue <[email protected]>
Collaborator
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhangyue [email protected]
Ⅰ. Describe what this PR did
As the title desc, but just part of this issue.
Ⅱ. Does this pull request fix one issue?
ref #2495
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
just refactor, no need.
Ⅳ. Describe how to verify it
wait for CI pass.
Ⅴ. Special notes for reviews
leave some of issue, and I add more comment in the issue #2495