Skip to content

Conversation

@zhuangqh
Copy link
Contributor

@zhuangqh zhuangqh commented Nov 6, 2018

Signed-off-by: zhuangqh [email protected]

Ⅰ. Describe what this PR did

rdebug.SetTraceback("all")

print stack trace of all of the go routine created by user if panic

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

print stack trace of all of the go routine created by user
if panic

Signed-off-by: zhuangqh <[email protected]>
@zhuangqh zhuangqh requested a review from fuweid November 6, 2018 07:32
@pouchrobot pouchrobot added kind/bug This is bug report for project kind/feature size/XS labels Nov 6, 2018
@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #2435 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2435      +/-   ##
==========================================
- Coverage    68.8%   68.72%   -0.08%     
==========================================
  Files         272      272              
  Lines       18175    18177       +2     
==========================================
- Hits        12506    12493      -13     
- Misses       4253     4261       +8     
- Partials     1416     1423       +7
Flag Coverage Δ
#criv1alpha1test 31.59% <100%> (+0.07%) ⬆️
#criv1alpha2test 35.6% <100%> (-0.21%) ⬇️
#integrationtest 40.13% <100%> (ø) ⬆️
#nodee2etest 32.9% <100%> (-0.14%) ⬇️
#unittest 26.52% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pkg/debug/debug.go 30% <100%> (+7.77%) ⬆️
daemon/mgr/snapshot.go 89.85% <0%> (-4.35%) ⬇️
cri/v1alpha2/cri_wrapper.go 62.4% <0%> (-1.21%) ⬇️
cri/v1alpha2/cri.go 67.68% <0%> (-0.86%) ⬇️
ctrd/container.go 58.49% <0%> (-0.8%) ⬇️
daemon/mgr/container.go 58.57% <0%> (-0.44%) ⬇️
cri/v1alpha1/cri.go 60.92% <0%> (+0.33%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
pkg/streams/utils.go 91.66% <0%> (+2.38%) ⬆️

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 4968f0e into AliyunContainerService:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug This is bug report for project kind/feature size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants