Skip to content

Conversation

@allencloud
Copy link
Collaborator

Signed-off-by: Allen Sun [email protected]

Ⅰ. Describe what this PR did

remove pouchcontainer/swagger since we use official one.

In pr #2350 we upgrade swagger to 0.17.1, then we should abandon the swagger from PouchContainer org https://github.com/pouchcontainer/tools/blob/master/bin/swagger

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need

Ⅳ. Describe how to verify it

none

Ⅴ. Special notes for reviews

also cc @zhuangqh

@codecov
Copy link

codecov bot commented Nov 4, 2018

Codecov Report

Merging #2420 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2420      +/-   ##
==========================================
+ Coverage   68.44%   68.53%   +0.09%     
==========================================
  Files         275      275              
  Lines       18309    18309              
==========================================
+ Hits        12531    12548      +17     
+ Misses       4349     4339      -10     
+ Partials     1429     1422       -7
Flag Coverage Δ
#criv1alpha1test 31.78% <ø> (-0.02%) ⬇️
#criv1alpha2test 35.68% <ø> (-0.15%) ⬇️
#integrationtest 39.85% <ø> (+0.01%) ⬆️
#nodee2etest 33.32% <ø> (+0.22%) ⬆️
#unittest 25.49% <ø> (ø) ⬆️
Impacted Files Coverage Δ
daemon/containerio/cri_log_file.go 84.31% <0%> (-3.93%) ⬇️
ctrd/image.go 76.75% <0%> (-2.2%) ⬇️
cri/v1alpha2/cri_wrapper.go 62.4% <0%> (-1.21%) ⬇️
cri/v1alpha2/cri.go 68.05% <0%> (+0.23%) ⬆️
daemon/mgr/container.go 60.66% <0%> (+0.42%) ⬆️
cri/v1alpha2/cri_utils.go 91.09% <0%> (+0.57%) ⬆️
ctrd/container.go 59.28% <0%> (+0.95%) ⬆️
ctrd/client.go 69.23% <0%> (+2.3%) ⬆️
daemon/mgr/events.go 100% <0%> (+3.7%) ⬆️
apis/server/utils.go 75% <0%> (+3.84%) ⬆️
... and 1 more

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit eb49d7c into AliyunContainerService:master Nov 4, 2018
echo ">>>> install swagger-${SWAGGER_VERSION} <<<<"
local url
url="https://raw.githubusercontent.com/pouchcontainer/tools/master/bin/swagger"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant space here ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants