tools: remove package builder from pouch #2398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we release pouch to yum/apt source, always needs to update builder script. It will change the git commit id. Sometimes, the changes doesn't belongs to the release version. Based on this case, using other repo to handle the package builder is better than current one. Signed-off-by: Wei Fu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2398 +/- ##
==========================================
+ Coverage 64.14% 68.49% +4.34%
==========================================
Files 275 275
Lines 18261 18261
==========================================
+ Hits 11713 12507 +794
+ Misses 5275 4336 -939
- Partials 1273 1418 +145
|
|
@sunyuan3 @chuanchang @Ace-Tang @CodeJuan PTAL Thanks. |
|
LGTM |
pouchrobot
added
the
LGTM
|
@fuweid LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wei Fu [email protected]
Ⅰ. Describe what this PR did
When we release pouch to yum/apt source, always needs to update builder
script. It will change the git commit id. Sometimes, the changes doesn't
belongs to the release version.
Based on this case, using other repo to handle the package builder is
better than current one.
All related builder scripts are moved to https://github.com/pouchcontainer/project.
The project shows us how to build deb/rpm packages.
Ⅱ. Does this pull request fix one issue?
related issues
fixes #2358
fixes #2357
fixes #2280
fixes #2232
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
no need
Ⅳ. Describe how to verify it
wait for CI
Ⅴ. Special notes for reviews