refactor: combine functions into one file #2390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since these functions like GetDevID, GetNodeIP ..., they all related to the host system info, just move them into one file, and easy to controll. Signed-off-by: Ace-Tang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2390 +/- ##
==========================================
+ Coverage 68.29% 68.32% +0.02%
==========================================
Files 265 261 -4
Lines 18211 18211
==========================================
+ Hits 12437 12442 +5
+ Misses 4357 4351 -6
- Partials 1417 1418 +1
|
|
Want to resolve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since these functions like GetDevID, GetNodeIP ..., they all related
to the host system info, just move them into one file, and easy to
controll.
Signed-off-by: Ace-Tang [email protected]
Ⅰ. Describe what this PR did
since these functions like GetDevID, GetNodeIP ..., they all related
to the host system info, just move them into one file, and easy to
controll.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews