Skip to content

Conversation

@ZYecho
Copy link
Contributor

@ZYecho ZYecho commented Oct 23, 2018

Signed-off-by: zhangyue [email protected]

Ⅰ. Describe what this PR did

As the title told, the checkpoint func named TestStartContainerTwice was leaved in cli_stop_test.go file, which was a wrong place to maintain,just fix it and add clean container operation.

Ⅱ. Does this pull request fix one issue?

None.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

None.

Ⅳ. Describe how to verify it

None.

Ⅴ. Special notes for reviews

None.

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #2342 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2342      +/-   ##
==========================================
+ Coverage   67.45%   67.51%   +0.06%     
==========================================
  Files         218      218              
  Lines       17678    17678              
==========================================
+ Hits        11925    11936      +11     
+ Misses       4351     4345       -6     
+ Partials     1402     1397       -5
Flag Coverage Δ
#criv1alpha1test 32.18% <ø> (-0.12%) ⬇️
#criv1alpha2test 36.24% <ø> (-0.22%) ⬇️
#integrationtest 40.42% <ø> (ø) ⬆️
#nodee2etest 33.78% <ø> (+0.22%) ⬆️
#unittest 23.41% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/stream/httpstream/spdy/upgrade.go 54.28% <0%> (-5.72%) ⬇️
ctrd/watch.go 78.78% <0%> (-4.55%) ⬇️
pkg/meta/store.go 62.5% <0%> (-1.57%) ⬇️
daemon/mgr/container_utils.go 82.82% <0%> (-1.23%) ⬇️
daemon/mgr/container.go 59% <0%> (-0.22%) ⬇️
cri/v1alpha2/cri_utils.go 90.57% <0%> (+0.28%) ⬆️
cri/v1alpha1/cri.go 61.03% <0%> (+0.32%) ⬆️
cri/v1alpha2/cri.go 68.52% <0%> (+0.6%) ⬆️
cri/v1alpha2/cri_wrapper.go 62.4% <0%> (+1.19%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
... and 2 more

@Ace-Tang
Copy link
Contributor

Make sense, LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Oct 23, 2018
@allencloud allencloud merged commit b093808 into AliyunContainerService:master Oct 23, 2018
@ZYecho ZYecho deleted the fix-start-test branch November 6, 2018 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants