Skip to content

Conversation

@chuanchang
Copy link
Contributor

Add new checkpoints into ports testing.

Signed-off-by: Alex Jia [email protected]

Ⅰ. Describe what this PR did

As summary.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

go test

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #2332 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2332      +/-   ##
==========================================
- Coverage   67.47%   67.42%   -0.06%     
==========================================
  Files         218      218              
  Lines       17674    17674              
==========================================
- Hits        11925    11916       -9     
- Misses       4355     4360       +5     
- Partials     1394     1398       +4
Flag Coverage Δ
#criv1alpha1test 32.28% <ø> (-0.06%) ⬇️
#criv1alpha2test 36.27% <ø> (+0.01%) ⬆️
#integrationtest 40.43% <ø> (-0.07%) ⬇️
#nodee2etest 33.75% <ø> (+0.03%) ⬆️
#unittest 23.33% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
daemon/containerio/cri_log_file.go 84.31% <0%> (-3.93%) ⬇️
apis/server/utils.go 71.15% <0%> (-3.85%) ⬇️
cri/v1alpha2/cri_wrapper.go 61.2% <0%> (-3.6%) ⬇️
ctrd/image.go 76.75% <0%> (-2.2%) ⬇️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
daemon/mgr/container.go 58.78% <0%> (-0.22%) ⬇️
cri/v1alpha2/cri.go 68.85% <0%> (ø) ⬆️
cri/v1alpha2/cri_utils.go 90.57% <0%> (+0.28%) ⬆️
daemon/mgr/snapshot.go 94.2% <0%> (+4.34%) ⬆️
apis/opts/ports.go 82.6% <0%> (+8.69%) ⬆️
... and 1 more

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 4ff1fb2 into AliyunContainerService:master Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants