Skip to content

Conversation

@chuanchang
Copy link
Contributor

Add new checkpoints into restart policy testing
Signed-off-by: Alex Jia [email protected]

Ⅰ. Describe what this PR did

As summary

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

go test

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #2331 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2331      +/-   ##
==========================================
- Coverage   67.47%   67.37%   -0.11%     
==========================================
  Files         218      218              
  Lines       17674    17674              
==========================================
- Hits        11925    11907      -18     
- Misses       4355     4362       +7     
- Partials     1394     1405      +11
Flag Coverage Δ
#criv1alpha1test 32.31% <ø> (-0.03%) ⬇️
#criv1alpha2test 36.37% <ø> (+0.11%) ⬆️
#integrationtest 40.43% <ø> (-0.07%) ⬇️
#nodee2etest 33.6% <ø> (-0.12%) ⬇️
#unittest 23.36% <ø> (+0.04%) ⬆️
Impacted Files Coverage Δ
ctrd/watch.go 78.78% <0%> (-4.55%) ⬇️
daemon/containerio/cri_log_file.go 84.31% <0%> (-3.93%) ⬇️
cri/v1alpha2/cri_wrapper.go 62.4% <0%> (-2.4%) ⬇️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
pkg/meta/store.go 62.5% <0%> (-1.57%) ⬇️
daemon/mgr/container_utils.go 82.82% <0%> (-1.23%) ⬇️
cri/v1alpha2/cri.go 68.36% <0%> (-0.49%) ⬇️
daemon/mgr/container.go 58.56% <0%> (-0.44%) ⬇️
apis/opts/restart_policy.go 100% <0%> (+21.87%) ⬆️

@chuanchang chuanchang requested a review from HusterWan October 19, 2018 01:13
@CLAassistant
Copy link

CLAassistant commented Oct 19, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit e110aa9 into AliyunContainerService:master Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants