refactor: modify the definition of ContainerPlugin interface #2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2316 +/- ##
==========================================
+ Coverage 67.2% 67.38% +0.17%
==========================================
Files 213 213
Lines 17511 17510 -1
==========================================
+ Hits 11769 11799 +30
+ Misses 4341 4319 -22
+ Partials 1401 1392 -9
|
zhuangqh
changed the title
xiaoxubeii
reviewed
Oct 16, 2018
| // PreCreate defines plugin point where receives a container create request, in this plugin point user | ||
| // could change the container create body passed-in by http request body | ||
| PreCreate(io.ReadCloser) (io.ReadCloser, error) | ||
| PreCreate(*types.ContainerCreateConfig) error |
There was a problem hiding this comment.
Interface signature and return value are all different from origin, some files missing?
There was a problem hiding this comment.
@xiaoxubeii You are right...
Signed-off-by: zhuangqh <[email protected]>
zhuangqh
force-pushed
the
fix-container-plugin
branch
from
cda39d5 to
aa4ef5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhuangqh [email protected]
Signed-off-by: Wei Fu [email protected]
Ⅰ. Describe what this PR did
modify the definition of ContainerPlugin interface: PreCreate
Type
*types.ContainerCreateConfigwould be more generic, whileio.ReadCloserread only stream data.The CRI need to support the rich-mode container so that the create_hook_plugin should be handled in container_mgr.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
redesign the interface
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews