fix: remove fifo path if stdio is not initail #2302
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2302 +/- ##
==========================================
+ Coverage 66.61% 67.95% +1.33%
==========================================
Files 211 217 +6
Lines 17195 19972 +2777
==========================================
+ Hits 11455 13572 +2117
- Misses 4337 4838 +501
- Partials 1403 1562 +159
|
Collaborator
|
@zhuangqh Thanks for your contribution. 🍻 |
Contributor
|
Just for the logic, LGTM |
pouchrobot
added
the
LGTM
Ace-Tang
reviewed
Oct 10, 2018
| // judge stdin is initial, make logic same with copyIO. | ||
| if i, ok := stdin.(*ContainerIO); (ok && i == nil) || (stdin == nil) { | ||
| paths.In = "" | ||
| } |
Contributor
There was a problem hiding this comment.
I just wonder if this code is need here, code not so good.
Contributor
Author
There was a problem hiding this comment.
@Ace-Tang What did you concern about? Maybe we should use reflect.ValueOf(stdin).IsNil() to check whether stdin is nil?
zhuangqh
changed the title
Contributor
Author
|
There is a mechanism to promise |
Collaborator
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
remove fifo path if stdio is not initail
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews