- 
                Notifications
    
You must be signed in to change notification settings  - Fork 944
 
test: Add checkpoints for PouchRunBlkioSuite #2291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add checkpoints for PouchRunBlkioSuite #2291
Conversation
          Codecov Report
 @@            Coverage Diff            @@
##           master   #2291      +/-   ##
=========================================
+ Coverage   66.75%   66.8%   +0.04%     
=========================================
  Files         208     208              
  Lines       16971   16971              
=========================================
+ Hits        11329   11337       +8     
+ Misses       4275    4270       -5     
+ Partials     1367    1364       -3
 
  | 
    
| 
           
  | 
    
d6319df    to
    d847b5d      
    Compare
  
    | 
           basically, LGTM. But please rebase the commits into one 😄  | 
    
| 
           please check the error  | 
    
test.util.util: add new GetMajMinNumofDevice function to get
                major:minor device number
test.cli_run_blkio_test: add host and container checkpoints
Signed-off-by: Alex Jia <[email protected]>
    d847b5d    to
    1e36dc8      
    Compare
  
    | 
           @fuweid done, thanks for reviewing, and v2 patch is coming.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Add new checkpoints and make sure cgroup setting is valid in inspect of container, configuration of host and the container.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
$ go test -test.v -check.f PouchRunBlkioSuite
=== RUN Test
OK: 3 passed
--- PASS: Test (24.99s)
PASS
ok github.com/alibaba/pouch/test 25.103s
Ⅴ. Special notes for reviews