feature: support create a container with a given id #2231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangforthinker
force-pushed
the
feature/create-container-with-given-ID
branch
from
6822c14 to
95612ed
Compare
allencloud
changed the title
pouchrobot
added
kind/feature
conflict/needs-rebase
and removed
conflict/needs-rebase
labels
|
Could you please first to fix the conflict there in this pull request? @wangforthinker |
wangforthinker
force-pushed
the
feature/create-container-with-given-ID
branch
from
f8bdc3d to
bdbf90b
Compare
wangforthinker
force-pushed
the
feature/create-container-with-given-ID
branch
from
bdbf90b to
1244439
Compare
Codecov Report
@@ Coverage Diff @@
## master #2231 +/- ##
==========================================
+ Coverage 68.4% 68.48% +0.07%
==========================================
Files 271 271
Lines 18263 18281 +18
==========================================
+ Hits 12493 12519 +26
+ Misses 4347 4344 -3
+ Partials 1423 1418 -5
|
|
Could you please rebase to the latest master? @wangforthinker |
fuweid
previously requested changes
Sep 14, 2018
wangforthinker
force-pushed
the
feature/create-container-with-given-ID
branch
3 times, most recently
from
4234411 to
0a3d65a
Compare
fuweid
reviewed
Oct 24, 2018
wangforthinker
force-pushed
the
feature/create-container-with-given-ID
branch
from
0a3d65a to
25c25fb
Compare
wangforthinker
force-pushed
the
feature/create-container-with-given-ID
branch
from
25c25fb to
b07d39c
Compare
Signed-off-by: allen.wang <[email protected]>
wangforthinker
force-pushed
the
feature/create-container-with-given-ID
branch
from
b07d39c to
6ca9906
Compare
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: allen.wang [email protected]
Ⅰ. Describe what this PR did
it can create container with a given id.
Ⅱ. Does this pull request fix one issue?
fixes #2180
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
add test TestBasicWithSpecificID and TestInvalidSpecificID in api_container_create_test.go.
Ⅳ. Describe how to verify it
verify it by test.
Ⅴ. Special notes for reviews
none.