Skip to content

Conversation

@ofrzeta
Copy link
Contributor

@ofrzeta ofrzeta commented Sep 10, 2018

  • environment variables consistency
  • GOPATH defaults to $HOME/go starting with Go 1.8
  • minor typo

Signed-off-by: Oliver Frommel [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

- GOPATH defaults to $HOME/go starting with Go 1.8
- minor typo

Signed-off-by: Oliver Frommel <[email protected]>
@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @ofrzeta
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
wait for the CI

@codecov-io
Copy link

Codecov Report

Merging #2220 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2220      +/-   ##
=========================================
- Coverage   64.94%   64.9%   -0.05%     
=========================================
  Files         208     208              
  Lines       16728   16728              
=========================================
- Hits        10864   10857       -7     
- Misses       4517    4522       +5     
- Partials     1347    1349       +2
Flag Coverage Δ
#criv1alpha1test 32.99% <ø> (+0.01%) ⬆️
#criv1alpha2test 33.69% <ø> (+0.19%) ⬆️
#integrationtest 39.96% <ø> (-0.01%) ⬇️
#unittest 23.83% <ø> (ø) ⬆️
Impacted Files Coverage Δ
apis/server/utils.go 61.9% <0%> (-4.77%) ⬇️
ctrd/watch.go 75.75% <0%> (-4.55%) ⬇️
cri/v1alpha1/cri.go 62.22% <0%> (-0.34%) ⬇️
daemon/mgr/container.go 56.76% <0%> (-0.21%) ⬇️
cri/v1alpha2/cri.go 62.77% <0%> (+0.31%) ⬆️

@fuweid fuweid merged commit dd3b1aa into AliyunContainerService:master Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants