Skip to content

Conversation

@YaoZengzeng
Copy link
Contributor

@YaoZengzeng YaoZengzeng commented Sep 3, 2018

Ⅰ. Describe what this PR did

Now if we initialize CNI manager failed we only output the error message

And the CNI Manager will become a noop manager which implement all the interfaces but do nothing

Actually the noop CNI Manager is misleading which may make the user feel that everything is OK

So we should remove the noop CNI Manager and speak loudly when we initialize it failed.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added areas/network kind/bug This is bug report for project size/M labels Sep 3, 2018
@codecov-io
Copy link

Codecov Report

Merging #2194 into master will increase coverage by 0.09%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2194      +/-   ##
==========================================
+ Coverage   64.86%   64.95%   +0.09%     
==========================================
  Files         209      208       -1     
  Lines       16739    16732       -7     
==========================================
+ Hits        10858    10869      +11     
+ Misses       4527     4511      -16     
+ Partials     1354     1352       -2
Flag Coverage Δ
#criv1alpha1test 32.67% <30%> (-0.03%) ⬇️
#criv1alpha2test 33.63% <30%> (+0.18%) ⬆️
#integrationtest 39.91% <0%> (-0.02%) ⬇️
#unittest 23.95% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
cri/v1alpha1/cri.go 62.39% <33.33%> (-0.22%) ⬇️
cri/v1alpha2/cri.go 63.45% <33.33%> (+0.11%) ⬆️
cri/ocicni/cni_manager.go 60% <50%> (+3.9%) ⬆️
apis/server/utils.go 61.9% <0%> (-4.77%) ⬇️
pkg/meta/store.go 62.5% <0%> (-1.57%) ⬇️
daemon/mgr/container_utils.go 83.13% <0%> (-1.21%) ⬇️
ctrd/image.go 77.19% <0%> (+0.43%) ⬆️
daemon/mgr/container.go 56.98% <0%> (+0.61%) ⬆️
ctrd/container.go 53.82% <0%> (+0.95%) ⬆️
... and 1 more

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit a8a9d5a into AliyunContainerService:master Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

areas/network kind/bug This is bug report for project size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants