docs: add CRI enhancement into document #2159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2159 +/- ##
==========================================
+ Coverage 64.3% 64.36% +0.05%
==========================================
Files 209 209
Lines 16693 16709 +16
==========================================
+ Hits 10735 10754 +19
- Misses 4618 4623 +5
+ Partials 1340 1332 -8
|
starnop
force-pushed
the
cri-apis-change
branch
2 times, most recently
from
c498abd to
3b3e9b7
Compare
allencloud
reviewed
Aug 27, 2018
|
|
||
| ### What To Solve? | ||
|
|
||
| + After kubelet performs in-situ upgrade, the container after upgrade cannot delete the anonymous volume inherited. |
Collaborator
There was a problem hiding this comment.
What does in-situ mean?
allencloud
reviewed
Aug 27, 2018
|
|
||
| ## CreateContainer | ||
|
|
||
| ###What To Solve? |
Collaborator
There was a problem hiding this comment.
Please add a whitespace before What ?
starnop
force-pushed
the
cri-apis-change
branch
2 times, most recently
from
483fa3d to
8449a0a
Compare
Signed-off-by: Starnop <[email protected]>
starnop
force-pushed
the
cri-apis-change
branch
from
8449a0a to
ccf6273
Compare
Collaborator
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Starnop [email protected]
Ⅰ. Describe what this PR did
docs: add CRI enhancement into document
Ⅱ. Does this pull request fix one issue?
fixes #2150
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews