Skip to content

Conversation

@Ace-Tang
Copy link
Contributor

if condition should change location, or runtime script path
will be coverd by runtime path.

Signed-off-by: Ace-Tang [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

if condition should change location, or runtime script path
will be coverd by runtime path.

Signed-off-by: Ace-Tang <[email protected]>
@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Aug 22, 2018
@codecov-io
Copy link

Codecov Report

Merging #2141 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2141      +/-   ##
==========================================
+ Coverage   64.44%   64.45%   +0.01%     
==========================================
  Files         209      209              
  Lines       16629    16629              
==========================================
+ Hits        10717    10719       +2     
  Misses       4585     4585              
+ Partials     1327     1325       -2
Flag Coverage Δ
#criv1alpha1test 33.05% <0%> (-0.03%) ⬇️
#criv1alpha2test 33.45% <0%> (+0.03%) ⬆️
#integrationtest 39.29% <0%> (-0.02%) ⬇️
#unittest 23.91% <0%> (ø) ⬆️
Impacted Files Coverage Δ
daemon/mgr/container_utils.go 83.13% <0%> (ø) ⬆️
apis/server/utils.go 61.9% <0%> (-4.77%) ⬇️
daemon/mgr/snapshot.go 89.85% <0%> (-4.35%) ⬇️
daemon/mgr/container.go 56.86% <0%> (+0.2%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
ctrd/watch.go 80.3% <0%> (+4.54%) ⬆️

@CodeJuan
Copy link
Contributor

LGTM

@CodeJuan CodeJuan merged commit f456439 into AliyunContainerService:master Aug 22, 2018
@Ace-Tang Ace-Tang deleted the runtime_args branch August 23, 2018 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug This is bug report for project size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants