refactor: support specify Namespace by user #2106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Wan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2106 +/- ##
==========================================
- Coverage 65.14% 65.09% -0.05%
==========================================
Files 208 208
Lines 16407 16405 -2
==========================================
- Hits 10688 10679 -9
- Misses 4388 4395 +7
Partials 1331 1331
|
allencloud
requested changes
Aug 17, 2018
There was a problem hiding this comment.
I think we can add a test for this. Since you configured the pouchd, something would change in the container inspect result, like a sub string of BaseFs. @HusterWan
|
@allencloud , we can add auto-testing later. The change looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Wan [email protected]
Ⅰ. Describe what this PR did
Add a flag
default-namespacefor pouchd, so that we can configure the namespace for containerd.Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews