bugfix: fix that ContainerManager.Create wouldn't remove snapshot when failed

[xiaoxubeii]

Ⅰ. Describe what this PR did

Fix that ContainerManager.Create wouldn't remove snapshot when failed.

Ⅱ. Does this pull request fix one issue?

fixes #2061.

Ⅲ. Describe how you did it

Add a variable cleanups to hold cleanup function, and loop it when failed in defer.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

[codecov-io]

Codecov Report

Merging #2080 into master will increase coverage by 25.56%.
The diff coverage is 84.61%.

@@             Coverage Diff             @@
##           master    #2080       +/-   ##
===========================================
+ Coverage   39.41%   64.97%   +25.56%     
===========================================
  Files         212      209        -3     
  Lines       16462    16239      -223     
===========================================
+ Hits         6488    10551     +4063     
+ Misses       8955     4375     -4580     
- Partials     1019     1313      +294

Flag	Coverage Δ
#criv1alpha1test	33.37% <23.07%> (+25.15%)	⬆️
#criv1alpha2test	33.84% <23.07%> (?)
#integrationtest	39.97% <84.61%> (+0.56%)	⬆️
#unittest	23.79% <0%> (?)

Impacted Files	Coverage Δ
daemon/mgr/container.go	55.97% <84.61%> (+2.78%)	⬆️
ctrd/events.go	75% <0%> (-6.82%)	⬇️
ctrd/client.go	56.87% <0%> (-0.21%)	⬇️
storage/volume/types/meta/meta.go	0% <0%> (ø)	⬆️
storage/volume/types/vars.go
storage/volume/types/meta/convert.go
storage/quota/set_diskquota.go
daemon/mgr/container_storage.go	49.48% <0%> (+0.51%)	⬆️
daemon/daemon.go	58.79% <0%> (+1.09%)	⬆️
ctrd/container.go	43.5% <0%> (+1.44%)	⬆️
... and 105 more

[allencloud]

Thanks a lot for your contribution. Just double check could we add an integration test for this case? @xiaoxubeii @rudyfly

[xiaoxubeii]

@allencloud OK, i will add a new integration testcase.

[allencloud]

OK, i will add a new integration testcase.

That could not be better. Thanks a lot. @xiaoxubeii

[xiaoxubeii]

@allencloud I find it is a little difficult to add a integration testcase of snapshot cleanup. That is because there is no api interface to list snapshots and i also cannot access containerd directly because of lacking the configuration. Any idea can help me to test?

[fuweid]

could we add some log here?

[pouchrobot]

@xiaoxubeii Thanks for your contribution. 🍻
Please sign off in each of your commits.

[allencloud]

LGTM

[allencloud]

Thanks for your great work. 🍺 @xiaoxubeii