Skip to content

Conversation

@starnop
Copy link
Contributor

@starnop starnop commented Aug 7, 2018

Signed-off-by: Starnop [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes part of #1756

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 7, 2018

Codecov Report

Merging #2062 into master will increase coverage by 3.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2062      +/-   ##
==========================================
+ Coverage   58.74%   62.53%   +3.78%     
==========================================
  Files         202      202              
  Lines       15535    16516     +981     
==========================================
+ Hits         9126    10328    +1202     
+ Misses       5301     4886     -415     
- Partials     1108     1302     +194
Flag Coverage Δ
#criv1alpha1test 33.56% <ø> (-0.15%) ⬇️
#criv1alpha2test 34.23% <ø> (?)
#integrationtest 38.42% <ø> (-0.06%) ⬇️
#unittest 23.34% <ø> (+0.17%) ⬆️
Impacted Files Coverage Δ
daemon/mgr/container.go 46.3% <0%> (-7.59%) ⬇️
ctrd/image.go 78.81% <0%> (-2.47%) ⬇️
ctrd/container.go 47.84% <0%> (-2.33%) ⬇️
cri/stream/remotecommand/httpstream.go 47.75% <0%> (-1.88%) ⬇️
cri/v1alpha1/cri_utils.go 84.16% <0%> (+0.71%) ⬆️
cri/stream/runtime.go 72.72% <0%> (+1.29%) ⬆️
daemon/mgr/container_exec.go 72.3% <0%> (+1.47%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
ctrd/watch.go 75.75% <0%> (+3.03%) ⬆️
cri/stream/remotecommand/exec.go 50% <0%> (+13.33%) ⬆️
... and 8 more

@starnop starnop force-pushed the cri-test-modifyContainerConfig branch from 6271053 to 7bf67bf Compare August 8, 2018 04:40
@YaoZengzeng
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants