Skip to content

Conversation

@Ace-Tang
Copy link
Contributor

@Ace-Tang Ace-Tang commented Aug 7, 2018

bash completion does autocompletion for pouch/pouchd command,
support command and flags completion for pouch, support flags
completion for pouchd.

Signed-off-by: Ace-Tang [email protected]

Ⅰ. Describe what this PR did

As I memtioned in #2058, this pr provide bash completion for pouch/pouchd.
But it only implement comands and options completion, more funtion need to be support in feature prs.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 8, 2018

Codecov Report

Merging #2059 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2059   +/-   ##
=======================================
  Coverage   63.93%   63.93%           
=======================================
  Files         206      206           
  Lines       15762    15762           
=======================================
  Hits        10077    10077           
  Misses       4435     4435           
  Partials     1250     1250
Flag Coverage Δ
#criv1alpha1test 33.23% <ø> (-0.04%) ⬇️
#criv1alpha2test 33.9% <ø> (-0.06%) ⬇️
#integrationtest 37.89% <ø> (ø) ⬆️
#unittest 23.77% <ø> (ø) ⬆️
Impacted Files Coverage Δ
ctrd/watch.go 72.72% <0%> (-3.04%) ⬇️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️

bash completion does autocompletion for pouch/pouchd command,
support command and flags completion for pouch, support flags
completion for pouchd.

Signed-off-by: Ace-Tang <[email protected]>
@rudyfly rudyfly merged commit 218807c into AliyunContainerService:master Aug 10, 2018
@rudyfly
Copy link
Collaborator

rudyfly commented Aug 10, 2018

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants