bugfix: makeup logpath from sandbox & container mata #2054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaoZengzeng
force-pushed
the
log
branch
2 times, most recently
from
2076240 to
d73ff34
Compare
Signed-off-by: YaoZengzeng <[email protected]>
fuweid
suggested changes
Aug 6, 2018
Contributor
fuweid
left a comment
fuweid
left a comment
There was a problem hiding this comment.
[Fail] [k8s.io] Container runtime should support adding volume and device [Conformance] [It] runtime should support starting container with volume [Conformance]
/home/travis/gopath/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/container.go:166
The case fails and please take a look
Codecov Report
@@ Coverage Diff @@
## master #2054 +/- ##
==========================================
+ Coverage 63.98% 64.01% +0.02%
==========================================
Files 202 202
Lines 15491 15510 +19
==========================================
+ Hits 9912 9928 +16
- Misses 4341 4343 +2
- Partials 1238 1239 +1
|
Contributor
Author
|
@fuweid PTAL |
fuweid
approved these changes
Aug 6, 2018
Contributor
fuweid
left a comment
fuweid
left a comment
There was a problem hiding this comment.
LGTM, since the fail is caused by non-blocked IO stream
This was referenced Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews