docs: update install step in INSTALLATION.md #2045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuweid
reviewed
Aug 2, 2018
INSTALLATION.md
Outdated
| ``` | ||
|
|
||
| Makefile target named `build` will compile the pouch and pouchd binaries in current work directory. Or you can just execute `make install` to build binaries and install them in destination directory (`/usr/local/bin` by default). | ||
| Makefile target named `build` will compile the pouch and pouchd binaries in current work directory. You can execute `make build && make install` to build binaries and install them in destination directory (`/usr/local/bin` by default). |
There was a problem hiding this comment.
build into bin directory actually 😄
There was a problem hiding this comment.
Yes, the make build would generate bin file into bin directory and make install would copy(or link?) this bin file to /usr/local/bin directory, is this pr anything wrong?
There was a problem hiding this comment.
I think we should update here the pouch and pouchd binaries in current work directory .
There was a problem hiding this comment.
OK, Got it. Thanks.
|
This change is done by @fuweid |
Signed-off-by: xiechengsheng <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2045 +/- ##
===========================================
+ Coverage 51.18% 63.73% +12.54%
===========================================
Files 200 201 +1
Lines 15531 15527 -4
===========================================
+ Hits 7950 9896 +1946
+ Misses 6513 4392 -2121
- Partials 1068 1239 +171
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiechengsheng [email protected]
Ⅰ. Describe what this PR did
Since the Makefile has been updated by previous PR, the install step in
INSTALLATION.mdshould also be updated.Ⅱ. Does this pull request fix one issue?
None
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews