Skip to content

Conversation

@allencloud
Copy link
Collaborator

Signed-off-by: Allen Sun [email protected]

Ⅰ. Describe what this PR did

This is a duplicate of #1751. I think we need this pull request urgently. So I put forward another one to cover this.

This PR update the error message with more details, while not modify the error type and status code .

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Describe how you did it

none

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Jul 31, 2018
@codecov-io
Copy link

Codecov Report

Merging #1960 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1960      +/-   ##
==========================================
- Coverage   63.31%   63.23%   -0.08%     
==========================================
  Files         200      200              
  Lines       15522    15522              
==========================================
- Hits         9828     9816      -12     
- Misses       4455     4461       +6     
- Partials     1239     1245       +6
Flag Coverage Δ
#criv1alpha1test 33.78% <0%> (-0.08%) ⬇️
#criv1alpha2test 34.24% <0%> (-0.04%) ⬇️
#integrationtest 38.39% <0%> (-0.04%) ⬇️
#unittest 20.86% <0%> (ø) ⬆️
Impacted Files Coverage Δ
ctrd/watch.go 75.75% <0%> (ø) ⬆️
ctrd/image.go 79.31% <0%> (-1.98%) ⬇️
ctrd/container.go 51.54% <0%> (-0.69%) ⬇️
daemon/mgr/container.go 53.69% <0%> (-0.32%) ⬇️
cri/v1alpha1/cri.go 65.4% <0%> (-0.19%) ⬇️
cri/v1alpha2/cri.go 66.31% <0%> (-0.18%) ⬇️

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 62c15a7 into AliyunContainerService:master Jul 31, 2018
@allencloud allencloud deleted the more-err branch July 31, 2018 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug This is bug report for project size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants