Skip to content

Conversation

@shaloulcy
Copy link
Contributor

Signed-off-by: Eric Li [email protected]

Ⅰ. Describe what this PR did

bugfix: fix panic for AttachVolume unittests

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added areas/storage areas/test kind/bug This is bug report for project kind/panic priority/P1 this is high priority that all maintainers should stop to handle this issue size/XS labels Jul 30, 2018
@codecov-io
Copy link

Codecov Report

Merging #1923 into master will increase coverage by 0.32%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1923      +/-   ##
==========================================
+ Coverage    62.3%   62.62%   +0.32%     
==========================================
  Files         200      200              
  Lines       15567    15573       +6     
==========================================
+ Hits         9699     9753      +54     
+ Misses       4609     4569      -40     
+ Partials     1259     1251       -8
Flag Coverage Δ
#criv1alpha1test 33.12% <0%> (-0.17%) ⬇️
#criv1alpha2test 33.66% <0%> (-0.04%) ⬇️
#integrationtest 37.97% <0%> (+0.02%) ⬆️
#unittest 20.48% <ø> (ø) ⬆️
Impacted Files Coverage Δ
storage/volume/types/volume_util.go 15.82% <0%> (-0.63%) ⬇️
cri/v1alpha2/cri.go 65.96% <0%> (-0.18%) ⬇️
daemon/mgr/container.go 54% <0%> (+0.15%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
daemon/mgr/system.go 75% <0%> (+1.72%) ⬆️
daemon/mgr/container_utils.go 58% <0%> (+1.73%) ⬆️
ctrd/image.go 81.18% <0%> (+1.98%) ⬆️
daemon/mgr/image_utils.go 85.45% <0%> (+3.63%) ⬆️
daemon/containerio/options.go 80.95% <0%> (+4.76%) ⬆️
pkg/meta/store.go 59.52% <0%> (+4.76%) ⬆️
... and 4 more

@allencloud
Copy link
Collaborator

Could you give more details about where panic? show some test logs? @shaloulcy

@rudyfly
Copy link
Collaborator

rudyfly commented Aug 7, 2018

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Aug 7, 2018
@rudyfly rudyfly merged commit 6da2d55 into AliyunContainerService:master Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

areas/storage areas/test kind/bug This is bug report for project kind/panic LGTM one maintainer or community participant agrees to merge the pull reuqest. priority/P1 this is high priority that all maintainers should stop to handle this issue size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants