feature: add CriEnabled field in api and show this in cli #1918
+64
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
force-pushed
the
add-crienabled
branch
2 times, most recently
from
a6fcec4 to
ebbd0d1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1918 +/- ##
==========================================
+ Coverage 62.8% 62.81% +<.01%
==========================================
Files 200 200
Lines 15567 15568 +1
==========================================
+ Hits 9777 9779 +2
- Misses 4544 4545 +1
+ Partials 1246 1244 -2
|
YaoZengzeng
reviewed
Jul 30, 2018
test/z_cli_daemon_test.go
Outdated
| "--enable-cri") | ||
| c.Assert(err, check.IsNil) | ||
|
|
||
| // Check pull image with default registry using the registry specified in daemon. |
Contributor
There was a problem hiding this comment.
This comment is not appropriate 😄
Contributor
|
LGTM, except the minor issue mentioned above :) |
Signed-off-by: Allen Sun <[email protected]>
allencloud
force-pushed
the
add-crienabled
branch
from
ebbd0d1 to
b135c2f
Compare
Collaborator
Author
|
Thanks for your review. @YaoZengzeng |
Contributor
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun [email protected]
Ⅰ. Describe what this PR did
In daemon's API side, we need to provide a user-friendly way for user to check if the pouchd is opening for CRI part.
Otherwise, user can only use
ps aux | grep pouchd | grep cri-enableto check, which is quite inconvenient. In addition, if a pouch client can only access pouchd remotely, no info can be gotten with this way. So, I think we need to add CriEnabled field in api and show this in cli.Ⅱ. Does this pull request fix one issue?
fixes #1908
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
execute
pouch info, you will seeCriEnabled: falseif no cri-enabled, otherwise, true.Ⅴ. Special notes for reviews
none