bugfix: avoid task exit channel exit unexpected #1765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when containerd stop unexpected, we should judge exit time is zero, zero exit time means grpc connection is broken. Signed-off-by: Ace-Tang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1765 +/- ##
==========================================
+ Coverage 56.32% 56.38% +0.06%
==========================================
Files 200 200
Lines 15657 15659 +2
==========================================
+ Hits 8819 8830 +11
+ Misses 5742 5736 -6
+ Partials 1096 1093 -3
|
|
PTAL， @HusterWan |
HusterWan
reviewed
Jul 24, 2018
| // isContainerdDead only take effect when contained stop normal, if containerd | ||
| // stop unexpected, judge exit time is zero, zero exit time means grpc connection | ||
| // is broken. | ||
| if status.ExitTime().IsZero() { |
There was a problem hiding this comment.
should also create a pr in gitlab?
There was a problem hiding this comment.
Sure, if you have look at it.
|
lgtm |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when containerd stop unexpected, we should judge exit time is zero,
zero exit time means grpc connection is broken.
Signed-off-by: Ace-Tang [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
step to verify the patch
Ⅴ. Special notes for reviews