bugfix: Fix log-opt option parse fails if value contains comma #1729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pflag.StringSliceVar will split the value into string array with comma, instead pflag.StringArrayVar will pass the value as a whole string, so we should use StringArrayVar if we intend to pass the value into other component.
|
@Frankzhaopku Thanks for your contribution. 🍻 |
frank-zsy
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1729 +/- ##
==========================================
+ Coverage 41.32% 41.39% +0.07%
==========================================
Files 277 277
Lines 18209 18209
==========================================
+ Hits 7524 7537 +13
+ Misses 9754 9743 -11
+ Partials 931 929 -2
|
|
LGTM |
1 similar comment
|
LGTM |
|
close #1715 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pflag.StringSliceVar will split the value into string array with
comma, instead pflag.StringArrayVar will pass the value as a whole
string, so we should use StringArrayVar if we intend to pass the
value into other component.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fix #1715
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews