test: add unit test for filter validation #1718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1718 +/- ##
==========================================
- Coverage 41.35% 40.78% -0.58%
==========================================
Files 277 275 -2
Lines 18209 18401 +192
==========================================
- Hits 7530 7504 -26
- Misses 9747 9968 +221
+ Partials 932 929 -3
|
Ace-Tang
reviewed
Jul 12, 2018
pkg/utils/filters/filter_test.go
Outdated
| wantErr bool | ||
| }{ | ||
| { | ||
| name: "", |
Contributor
There was a problem hiding this comment.
How about make name readable?
Collaborator
Author
There was a problem hiding this comment.
cannot agree more. Thanks. and updated. @Ace-Tang
Signed-off-by: Allen Sun <[email protected]>
Contributor
|
lgtm |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun [email protected]
Ⅰ. Describe what this PR did
This pull request add unit test for function validate of filter.
Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Describe how you did it
none
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none